On Aug 18 14:45, Corinna Vinschen wrote: > On Aug 18 11:23, Damien Miller wrote: > > Hi, > > > > OpenSSH 6.7 is almost ready for release, so we would appreciate testing > > on as many platforms and systems as possible. This is a big release > > containing a number of features, a lot of internal refactoring and some > > potentially-incompatible changes. > > > > Snapshot releases for portable OpenSSH are available from > > http://www.mindrot.org/openssh_snap/ > > I tested from CVS HEAD and there's a bug in serverloop.c. On systems > not defining NO_IPPORT_RESERVED_CONCEPT, a stray "||" leads to a syntax > error. Here's a patch: > > Index: serverloop.c > =================================================================== > RCS file: /cvs/openssh/serverloop.c,v > retrieving revision 1.181 > diff -u -p -r1.181 serverloop.c > --- serverloop.c 18 Jul 2014 04:11:26 -0000 1.181 > +++ serverloop.c 18 Aug 2014 12:33:02 -0000 > @@ -1173,9 +1173,9 @@ server_input_global_request(int type, u_ > /* check permissions */ > if ((options.allow_tcp_forwarding & FORWARD_REMOTE) == 0 || > no_port_forwarding_flag || > - (!want_reply && fwd.listen_port == 0) || > + (!want_reply && fwd.listen_port == 0) > #ifndef NO_IPPORT_RESERVED_CONCEPT > - (fwd.listen_port != 0 && fwd.listen_port < IPPORT_RESERVED && > + || (fwd.listen_port != 0 && fwd.listen_port < IPPORT_RESERVED && > pw->pw_uid != 0) > #endif > ) { > > Also, I can't run the testsuite on Cygwin anymore: > > $ make tests > [ -d `pwd`/regress ] || mkdir -p `pwd`/regress > [ -d `pwd`/regress/unittests ] || mkdir -p `pwd`/regress/unittests > [ -d `pwd`/regress/unittests/test_helper ] || \ > mkdir -p `pwd`/regress/unittests/test_helper > [ -d `pwd`/regress/unittests/sshbuf ] || \ > mkdir -p `pwd`/regress/unittests/sshbuf > [ -d `pwd`/regress/unittests/sshkey ] || \ > mkdir -p `pwd`/regress/unittests/sshkey > [ -f `pwd`/regress/Makefile ] || \ > ln -s `cd ../src && pwd`/regress/Makefile `pwd`/regress/Makefile > (cd openbsd-compat && make) > make[1]: Entering directory '/home/corinna/src/openssh/build/openbsd-compat' > make[1]: Nothing to be done for 'all'. > make[1]: Leaving directory '/home/corinna/src/openssh/build/openbsd-compat' > gcc -g -O2 [...options...] -o regress/modpipe.exe ../src/regress/modpipe.c \ > -L. -Lopenbsd-compat/ -fstack-protector-all -lssh -lopenbsd-compat -lssh -lopenbsd-compat -lcrypto -lz /usr/lib/textreadmode.o -lcrypt > gcc -g -O2 [...options...] -o regress/setuid-allowed.exe ../src/regress/setuid-allowed.c \ > -L. -Lopenbsd-compat/ -fstack-protector-all -lssh -lopenbsd-compat -lssh -lopenbsd-compat -lcrypto -lz /usr/lib/textreadmode.o -lcrypt > make: *** No rule to make target 'regress/unittests/sshbuf/tests.o', needed by 'regress/unittests/sshbuf/test_sshbuf.exe'. Stop. > > This is using GNU make. I'm not sure what's missing. Is that because > I'm not building in the source dir, by any chance? No, it's not. Even when building in the source dir, `make tests' fails as above. Corinna -- Corinna Vinschen Cygwin Maintainer Red Hat
Attachment:
pgp6haWOjhgdT.pgp
Description: PGP signature
_______________________________________________ openssh-unix-dev mailing list openssh-unix-dev@xxxxxxxxxxx https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
