Re: Read-only on /dev/tty causes ssh-add to show passwords when typed and ssh'ing to new hosts to fail

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



On 21/07/14 09:10, Gert Doering wrote:
Well, you already *have* that special case - "if /dev/tty isn't working,
assume we do not have a controlling tty and use stdin".  The question is
whether you can (and want to) distinguish "I have no controlling tty"
from "/dev/tty is messed up ->  print error and die".

gert

Well, if you consider ssh-add should fail in that case, you can simply do this:
diff --git a/ssh-add.c b/ssh-add.c
index 3421452..977b3f1 100644
--- a/ssh-add.c
+++ b/ssh-add.c
@@ -213,7 +213,7 @@ add_file(AuthenticationConnection *ac, const char *filename, int key_only)
                snprintf(msg, sizeof msg, "Enter passphrase for %.200s: ",
                    comment);
                for (;;) {
-                       pass = read_passphrase(msg, RP_ALLOW_STDIN);
+                       pass = read_passphrase(msg, 0);
                        if (strcmp(pass, "") == 0) {
                                clear_pass();
                                free(comment);


_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev




[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux