Folks,
Not very critical - but below would help make the PKCS#11 experience a bit smoother. The, occasionally informative, no-slots message is moved to ‚debug’; as otherwise, in a mixed pkcs#11 and file-based environment virtually all non chip-card driven ssh connections spew ‚no slot’ on stderr. And in day to day use - the only time you want this message is when you are debugging an issue; such as a faulty card or reader. Tested on freebsd and osx.
Thanks,
Dw.
diff -u openssh-6.6p1.orig/ssh-pkcs11.c openssh-6.6p1/ssh-pkcs11.c
--- openssh-6.6p1.orig/ssh-pkcs11.c 2014-06-04 10:19:09.000000000 +0200
+++ openssh-6.6p1/ssh-pkcs11.c 2014-06-04 10:20:29.000000000 +0200
@@ -602,7 +602,7 @@
goto fail;
}
if (p->nslots == 0) {
- error("no slots");
+ debug("no slots");
goto fail;
}
p->slotlist = xcalloc(p->nslots, sizeof(CK_SLOT_ID));
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev
