Sorry for no reply since last year.
I want to follow up this thread, it's almost a half year ago since my
original patch.
First, congratulations for 8.0 release!
Then, thank you so much for adding `--form-entry` (`-F`.)
This is actually sufficient to integrate Keychain without modifying
openconnect itself!
Also, I found a very trivial typo which the long option is the help
messages are not using `--form-entry` but `--form-field`.
Too minor, but it may reduce some confusions.
-- >8 --
Subject: [PATCH] Fix wrong long option is used in the help messages
`-F` has long option `--form-entry` and man page and many places are
all using `--form-entry`, however, help messages are using
`--form-field`.
Signed-off-by: Yoshimasa Niwa <niw@xxxxxx>
---
main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/main.c b/main.c
index 3a20bf0a..19d64377 100644
--- a/main.c
+++ b/main.c
@@ -805,7 +805,7 @@ static void usage(void)
printf(" --non-inter %s\n", _("Do not expect user input; exit if it is required"));
printf(" --passwd-on-stdin %s\n", _("Read password from standard input"));
printf(" --authgroup=GROUP %s\n", _("Choose authentication login selection"));
- printf(" -F, --form-field=FORM:OPT=VALUE %s\n", _("Provide authentication form responses"));
+ printf(" -F, --form-entry=FORM:OPT=VALUE %s\n", _("Provide authentication form responses"));
printf(" -c, --certificate=CERT %s\n", _("Use SSL client certificate CERT"));
printf(" -k, --sslkey=KEY %s\n", _("Use SSL private key file KEY"));
printf(" -e, --cert-expire-warning=DAYS %s\n", _("Warn when certificate lifetime < DAYS"));
@@ -1974,7 +1974,7 @@ static void add_form_field(char *arg)
if (!value || value == arg) {
bad_field:
- fprintf(stderr, "Form field invalid. Use --form-field=FORM_ID:OPT_NAME=VALUE\n");
+ fprintf(stderr, "Form field invalid. Use --form-entry=FORM_ID:OPT_NAME=VALUE\n");
exit(1);
}
*(value++) = 0;
--
Yoshimasa Niwa
_______________________________________________
openconnect-devel mailing list
openconnect-devel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/openconnect-devel
