On Wed, Apr 19, 2017 at 3:06 AM, David Woodhouse <dwmw2 at infradead.org> wrote: > > On Sun, 2017-04-09 at 02:03 -0700, Daniel Lenski wrote: > > Signed-off-by: Daniel Lenski <dlenski at gmail.com> > > --- > > library.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/library.c b/library.c > > index 86b524a..48f458a 100644 > > --- a/library.c > > +++ b/library.c > > @@ -178,7 +178,7 @@ int openconnect_get_supported_protocols(struct oc_vpn_proto **protos) > > pr->description = _(p->description); > > pr->flags = p->flags; > > } > > - return 0; > > + return (p - openconnect_protos); > > } > > > > void openconnect_free_supported_protocols(struct oc_vpn_proto *protos) > > Is there a reason not to collapse that into the previous commit? No reason other than that I wrote it separately and thought it was worth calling out. I can squash and resubmit. Assuming it's otherwise okay? are you planning to merge this soon? I already have it working with NetworkManager and I imagine that ?ubom?r Carik will be able to add support to openconnect-gui as well once the API is in place. -Dan