On Wed, Feb 10, 2016 at 1:28 PM, Woodhouse, David <david.woodhouse at intel.com> wrote: > On Mon, 2016-02-08 at 22:34 -0800, Kevin Cernekee wrote: >> This is missing on Chrome's Native Client (NaCl) because NaCl doesn't >> really have (traditional) filesystems. > > Should we have a feature test for statvfs() too? And use statfs by > preference where it's available? statfs() is deprecated in favor of statvfs(). But it looks like statvfs() truncates the FSID to 32 bits when sizeof(long) == 4. Is that why you'd prefer statfs() when it is available? I guess I should probably avoid including <sys/statfs.h> if !HAVE_STATFS, too.