On Wed, 2016-12-14 at 10:02 -0800, Mike Miller wrote: > On Wed, Dec 14, 2016 at 08:36:56 +0000, David Woodhouse wrote: > > Right. I was saying that we already create the .conf file at configure > > time, so we could create the .module file then too. > > > > But then again... why? My proposal for discovering where SoftHSM2 > > resides was just to look for an existing p11-kit module file in the > > system's configuration. And if we're going to require that the distro's > > packaging of SoftHSM is correct and installs it with a p11-kit .module > > file... then why do we need to bother messing with $HOME and providing > > our own in the first place? > > > > Let's just drop the whole nonsense and rely on the system packaging > > SoftHSM2 correctly. Does that seem reasonable? I suppose we could also > > add a --with-softhsm2= configure argument, but I'd prefer not to. > > Ok, I'll workaround locally for now and work to get the softhsm2 package > to pick up the slack. OK. I think I'll rip out the local .module file completely and just rely on SoftHSM being installed correctly ? or the user running the tests having installed their own .module file to work around system packaging if not. > Does this patch and commit message work better for you? Much better; thanks. -- dwmw2 -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 5760 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20161214/a4ff438a/attachment.bin>
