On Mon, Oct 27, 2014 at 1:51 PM, David Woodhouse <dwmw2 at infradead.org> wrote: > On Mon, 2014-10-27 at 10:49 +0100, Nikos Mavrogiannopoulos wrote: >> Hello, >> As it is now, a program using libopenconnect cannot get the >> ciphersuite in use in a session. This patch adds that API. > > You have a habit of sending me patches which give me more work to do :) > > Admittedly, I know I do the same to you, but you definitely won that > game by sending me a patch to make it *build* on Win32 without actually > doing anything useful, then letting my OCD kick in and figure out the > TAP-Windows driver and other issues :) :) > One remaining issue: can the cipher change on a rehandshake? If so, your > cached vpninfo->cstp_cipher string might get out of date, and it needs > to be freed and set to NULL on a renegotiate too. Yes, it could change. I'll check to it tomorrow. regards, Nikos
