On Sun, Aug 3, 2014 at 12:15 AM, David Woodhouse <dwmw2 at infradead.org> wrote: > On Sat, 2014-08-02 at 17:33 -0700, Kevin Cernekee wrote: >> + /* FIXME: UTF-8 fname may need conversion */ >> + fd = open(fname, O_RDONLY); > > We have a helper function open_utf8() for that which should just Do The > Right Thing?. It's only when you're passing the filename to an external > library that you have to think a little harder about how *it* will > handle it. OK - since this is called from the main executable I can add it to the OPENCONNECT_PRIVATE export list as-is, or rename it to openconnect_open_utf8() first? I wasn't 100% sure it was needed because there were a couple of other "raw" open() / fopen() calls in main.c. But it looks like all of the command line arguments do get translated into UTF-8 strings.
