On Sun, 2013-02-17 at 22:44 +0000, David Woodhouse wrote: > > > > We now have two callers of parse_xml_response() which do, and two which > > > don't. I'm suspect that's a bad thing, and we should put it *into* > > > parse_xml_response() rather than leaving it to the caller... > > > > For the XML POST case, I would expect no "action" attribute; > > everything always seems to get posted to the root URL. > > > > For the CSD case, the server probably shouldn't be changing the post > > URL just because we refreshed the login form post-CSD. If it does > > anyway, we might as well follow it. > > > > So this sounds like it would work OK. > > OK, I'll put it together and test the non-xmlpost side it. Thanks. Ah, handle_redirect() is local to http.c while parse_xml_response() is in auth.c. Probably isn't worth making it non-static because that will more than offset the minor cleanup effect I was intending... -- dwmw2 -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 6171 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20130217/f08080b4/attachment-0001.bin>
