On Thu, 2010-12-02 at 17:53 -0200, Murilo Opsfelder wrote: > By optional, you mean a "save password" checkbox in the GUI or a > compile-time flag (e.g.: --with-gnome-keyring)? The former. Or *some* way of exposing that choice to the user, at least. Web browsers do it differently, with a pop-up after a successful login. > > Secondly, it's saving the password even if the authentication fails. > > You'll note that 'remember_gconf_key' doesn't actually set it > > immediately; it just *stores* it, and the entry later gets set when the > > cookie_obtained() function walks through the ui_data->success_keys list. > > If I understood it correctly, in remember_keyring_key() I should only > store form_id, name and value in auth_ui_data and actually save them in > gnome-keyring inside cookie_obtained() function. Is that correct? Yes. So you're not storing the password when it was *wrong* :) -- dwmw2
