Don't check validity of asize second time once it has been checked before. Remove the duplicate code. Fixes: 556bdf27c2dd ("ntfs3: Add bounds checking to mi_enum_attr()") Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx> --- fs/ntfs3/record.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/ntfs3/record.c b/fs/ntfs3/record.c index 427c71be0f087..0f400366231d5 100644 --- a/fs/ntfs3/record.c +++ b/fs/ntfs3/record.c @@ -268,10 +268,6 @@ struct ATTRIB *mi_enum_attr(struct mft_inode *mi, struct ATTRIB *attr) /* Check size of attribute. */ if (!attr->non_res) { - /* Check resident fields. */ - if (asize < SIZEOF_RESIDENT) - return NULL; - t16 = le16_to_cpu(attr->res.data_off); if (t16 > asize) return NULL; -- 2.39.2