On 08.07.2024 09:54, Dmitry Vyukov wrote:
On Fri, 5 Jul 2024 at 15:52, Lizhi Xu <lizhi.xu@xxxxxxxxxxxxx> wrote:
On Thu, 4 Jul 2024 15:44:02 +0200, Dmitry Vyukov wrote:
index 53629b1f65e9..a435df98c2b1 100644
--- a/fs/ntfs3/record.c
+++ b/fs/ntfs3/record.c
@@ -243,14 +243,14 @@ struct ATTRIB *mi_enum_attr(struct mft_inode *mi, struct ATTRIB *attr)
off += asize;
}
- asize = le32_to_cpu(attr->size);
-
/* Can we use the first field (attr->type). */
if (off + 8 > used) {
static_assert(ALIGN(sizeof(enum ATTR_TYPE), 8) == 8);
return NULL;
}
+ asize = le32_to_cpu(attr->size);
+
if (attr->type == ATTR_END) {
/* End of enumeration. */
return NULL;
Hi Lizhi,
I don't see this fix mailed as a patch. Do you plan to submit it officially?
Hi Dmitry Vyukov,
Here: https://lore.kernel.org/all/20240202033334.1784409-1-lizhi.xu@xxxxxxxxxxxxx
I don't see this patch merged upstream. Was it lost? Perhaps it needs
to be resent.
Hi, Lizhi, Dmitry, This patch is indeed not present in either the
upstream or our repository. I will retest it and figure out why I didn't
add it. Around the same time, I was making changes to mi_enum_attr, so I
might have mixed something up. Thanks for your attention! Regards,
Konstantin
