On Thu, Jun 27, 2024 at 07:24:59PM GMT, Eric Sandeen wrote: > Multiple filesystems take uid and gid as options, and the code to > create the ID from an integer and validate it is standard boilerplate > that can be moved into common helper functions, so do that for > consistency and less cut&paste. > > This also helps avoid the buggy pattern noted by Seth Jenkins at > https://lore.kernel.org/lkml/CALxfFW4BXhEwxR0Q5LSkg-8Vb4r2MONKCcUCVioehXQKr35eHg@xxxxxxxxxxxxxx/ > because uid/gid parsing will fail before any assignment in most > filesystems. > > Net effect is a bit of code removal, as well. Thanks, this all looks good to me. I'll have one comment about the fuse patch.