On Thu, Sep 07, 2023 at 06:03:40PM +0200, Christian Brauner wrote: > Recently we moved most cleanup from ntfs_put_super() into > ntfs3_kill_sb() as part of a bigger cleanup. This accidently also moved > dropping inode references stashed in ntfs3's sb->s_fs_info from > @sb->put_super() to @sb->kill_sb(). But generic_shutdown_super() > verifies that there are no busy inodes past sb->put_super(). Fix this > and disentangle dropping inode references from freeing @sb->s_fs_info. Sorry for the delay, I've been travelling. Wouldn't it make more sense to just free it in ->kill_sb before calling kill_block_super? Either way the fix looks good, and as Linus has already applied it it's probably not worth arguing..
