Re: [PATCH] fs/ntfs3: Uninitialized variable bug in ntfs_d_compare()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14.10.2022 13:40, Dan Carpenter wrote:
Smatch detected an uninitialized variable bug:

     fs/ntfs3/namei.c:487 ntfs_d_compare() error: uninitialized symbol 'uni1'

Fixes: a3a956c78efa ("fs/ntfs3: Add option "nocase"")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
  fs/ntfs3/namei.c | 12 ++++--------
  1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c
index 315763eb05ff..5d3a6ce3f05f 100644
--- a/fs/ntfs3/namei.c
+++ b/fs/ntfs3/namei.c
@@ -431,10 +431,8 @@ static int ntfs_d_compare(const struct dentry *dentry, unsigned int len1,
/* First try fast implementation. */
  	for (;;) {
-		if (!lm--) {
-			ret = len1 == len2 ? 0 : 1;
-			goto out;
-		}
+		if (!lm--)
+			return len1 == len2 ? 0 : 1;
if ((c1 = *n1++) == (c2 = *n2++))
  			continue;
@@ -442,10 +440,8 @@ static int ntfs_d_compare(const struct dentry *dentry, unsigned int len1,
  		if (c1 >= 0x80 || c2 >= 0x80)
  			break;
- if (toupper(c1) != toupper(c2)) {
-			ret = 1;
-			goto out;
-		}
+		if (toupper(c1) != toupper(c2))
+			return 1;
  	}
/*

Thanks for work, this bug has already been fixed:

https://lore.kernel.org/ntfs3/20221004232359.285685-1-nathan@xxxxxxxxxx/





[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux