Re: [PATCH] fs/ntfs3: Use kmalloc_array for allocating multiple elements

[Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>]

On 8/19/22 08:51, Kenneth Lee wrote:
> Prefer using kmalloc_array(a, b) over kmalloc(a * b) as this
> improves semantics since kmalloc is intended for allocating an
> array of memory.
>
> Signed-off-by: Kenneth Lee <klee33@xxxxxx>
> ---
>   fs/ntfs3/bitmap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/bitmap.c b/fs/ntfs3/bitmap.c
> index 5d44ceac855b..1675c9a69788 100644
> --- a/fs/ntfs3/bitmap.c
> +++ b/fs/ntfs3/bitmap.c
> @@ -1324,7 +1324,7 @@ int wnd_extend(struct wnd_bitmap *wnd, size_t new_bits)
>   		new_last = wbits;
>   
>   	if (new_wnd != wnd->nwnd) {
> -		new_free = kmalloc(new_wnd * sizeof(u16), GFP_NOFS);
> +		new_free = kmalloc_array(new_wnd, sizeof(u16), GFP_NOFS);
>   		if (!new_free)
>   			return -ENOMEM;
>   

Applied, thanks!