On Mon, May 30, 2022 at 08:00:12AM -0400, Mikulas Patocka wrote:
> The ntfs3 filesystem lacks the 'invalidate_folio' method and it causes
> memory leak. If you write to the filesystem and then unmount it, the
> cached written data are not freed and they are permanently leaked.
>
> Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
> Reported-by: José Luis Lara Carrascal <manualinux@xxxxxxxx>
> Fixes: 7ba13abbd31e ("fs: Turn block_invalidatepage into block_invalidate_folio")
That commit is innocent here. Rather, this should be:
Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
Yes, trees before 7ba13abbd31e will need to change the patch to add
invalidate_page instead of invalidate_folio, but that's a normal part
of the process.
> Cc: stable@xxxxxxxxxxxxxxx # v5.18
>
> ---
> fs/ntfs3/inode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/fs/ntfs3/inode.c
> ===================================================================
> --- linux-2.6.orig/fs/ntfs3/inode.c 2022-05-16 16:57:24.000000000 +0200
> +++ linux-2.6/fs/ntfs3/inode.c 2022-05-30 13:36:45.000000000 +0200
> @@ -1951,6 +1951,7 @@ const struct address_space_operations nt
> .direct_IO = ntfs_direct_IO,
> .bmap = ntfs_bmap,
> .dirty_folio = block_dirty_folio,
> + .invalidate_folio = block_invalidate_folio,
> };
>
> const struct address_space_operations ntfs_aops_cmpr = {
