Re: [Ocfs2-devel] [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@xxxxxxxxxxxxxx>
Subject: Re: [Ocfs2-devel] [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 06 Apr 2022 23:34:27 -0400
Cc: Jens Axboe <axboe@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, dm-devel@xxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, ntfs3@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
In-reply-to: <20220406060516.409838-26-hch@lst.de> (Christoph Hellwig via Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:14 +0200")
Organization: Oracle Corporation
References: <20220406060516.409838-1-hch@lst.de> <20220406060516.409838-26-hch@lst.de>

Christoph,

> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.

Very happy to finally see this flag removed!

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- use block_device based APIs in block layer consumers
  - From: Christoph Hellwig
- [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD
  - From: Christoph Hellwig

Prev by Date: Re: [Ocfs2-devel] [PATCH 24/27] block: add a bdev_discard_granularity helper
Next by Date: Re: [Ocfs2-devel] [PATCH 23/27] block: add a bdev_max_discard_sectors helper
Previous by thread: [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD
Next by thread: Re: [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]