Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jinpu Wang <jinpu.wang@xxxxxxxxx>
Subject: Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 20 Jan 2022 09:37:46 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Pavel Begunkov <asml.silence@xxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, "Md . Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxx>, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, ntfs3@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx
In-reply-to: <CAMGffEmFZB1PPE09bfxQjKw-tJhdprEkF-OWrVF4Kjsf1OwQ_g@mail.gmail.com>
References: <20220118071952.1243143-1-hch@lst.de> <20220118071952.1243143-11-hch@lst.de> <CAMGffEmFZB1PPE09bfxQjKw-tJhdprEkF-OWrVF4Kjsf1OwQ_g@mail.gmail.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Jan 19, 2022 at 01:20:54AM +0100, Jinpu Wang wrote:
> this changes lead to IO error all the time, because bio_add_page return len.
> We need  if (bio_add_page(bio, virt_to_page(data), datalen,
>                      offset_in_page(data)) < datalen)

Does this version look good to you?

http://git.infradead.org/users/hch/block.git/commitdiff/62adb08e765b889dd8db4227cad33a710e36d631

Follow-Ups:
- Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma
  - From: Jinpu Wang

References:
- improve the bio allocation interface
  - From: Christoph Hellwig
- [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma
  - From: Christoph Hellwig
- Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma
  - From: Jinpu Wang

Prev by Date: Re: [PATCH 11/19] rnbd-src: remove struct rnbd_dev_blk_io
Next by Date: Re: [PATCH 14/19] block: pass a block_device and opf to blk_next_bio
Previous by thread: Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma
Next by thread: Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]