Re: [PATCH] checkpatch: Remove cvs keyword check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2021-10-27 at 02:16 +0300, Kari Argillander wrote:
> Time has pass and we do not need these anymore as almost all people are
> using git now days. Those who use cvs for kernel development probably
> will handle cvs pretty well already so this check is not needed anymore.

I think it's a relatively harmless thing to keep.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4017,12 +4017,6 @@ sub process {
>  			}
>  		}
>  
> -# check for RCS/CVS revision markers
> -		if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {

Looks like this would be better using

		if ($rawline =~ /^\+.*\b\$(?:Revision|Log|Id)\$?\b/) {

> -			WARN("CVS_KEYWORD",
> -			     "CVS style keyword markers, these will _not_ be updated\n". $herecurr);






[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux