On Fri, Oct 22, 2021 at 09:28:14AM +0800, Gao Xiang wrote: > On Thu, Oct 21, 2021 at 09:04:45PM -0400, Phillip Susi wrote: > > > > Matthew Wilcox <willy@xxxxxxxxxxxxx> writes: > > > > > As far as I can tell, the following filesystems support compressed data: > > > > > > bcachefs, btrfs, erofs, ntfs, squashfs, zisofs > > > > > > I'd like to make it easier and more efficient for filesystems to > > > implement compressed data. There are a lot of approaches in use today, > > > but none of them seem quite right to me. I'm going to lay out a few > > > design considerations next and then propose a solution. Feel free to > > > tell me I've got the constraints wrong, or suggest alternative solutions. > > > > > > When we call ->readahead from the VFS, the VFS has decided which pages > > > are going to be the most useful to bring in, but it doesn't know how > > > pages are bundled together into blocks. As I've learned from talking to > > > Gao Xiang, sometimes the filesystem doesn't know either, so this isn't > > > something we can teach the VFS. > > > > > > We (David) added readahead_expand() recently to let the filesystem > > > opportunistically add pages to the page cache "around" the area requested > > > by the VFS. That reduces the number of times the filesystem has to > > > decompress the same block. But it can fail (due to memory allocation > > > failures or pages already being present in the cache). So filesystems > > > still have to implement some kind of fallback. > > > > Wouldn't it be better to keep the *compressed* data in the cache and > > decompress it multiple times if needed rather than decompress it once > > and cache the decompressed data? You would use more CPU time > > decompressing multiple times, but be able to cache more data and avoid > > more disk IO, which is generally far slower than the CPU can decompress > > the data. > > Yes, that was also my another point yesterday talked on #xfs IRC. For > high-decompresion speed algorithms like lz4, yes, thinking about the > benefits of zcache or zram solutions, caching compressed data for > incomplete read requests is more effective than caching uncompressed > data (so we don't need zcache for EROFS at all). But if such data will > be used completely immediately, EROFS will only do inplace I/O only > (since cached compressed data can only increase memory overhead). > Also, considering some algorithms is slow, inplace I/O is more useful > for them. Anyway, it depends on the detail strategy of different > algorithms and can be fined later. > But I don't think endless compressed data caching is generally useful especially for devices that need extra memory as much possible (For example, we need to keep apps alive as many as possible in Android without jagging, otherwise it would be bad for user experience). So limited prefetching/caching only increasing memory reclaim overhead and page cache thrashing without benefits since compressed data cannot be used immediately without decompression. Thanks, Gao Xiang > Thanks, > Gao Xiang > > > > >
