Re: [PATCH 1/7] fs: remove __sync_filesystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH 1/7] fs: remove __sync_filesystem
From: Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>
Date: Tue, 19 Oct 2021 06:33:00 +0000
Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "ntfs3@xxxxxxxxxxxxxxx" <ntfs3@xxxxxxxxxxxxxxx>
In-reply-to: <20211019062530.2174626-2-hch@lst.de>
References: <20211019062530.2174626-1-hch@lst.de> <20211019062530.2174626-2-hch@lst.de>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

On 10/18/2021 11:25 PM, Christoph Hellwig wrote:
> There is no clear benefit in having this helper vs just open coding it.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Especially if there is only one caller.

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

References:
- cleanup block device inode syncing
  - From: Christoph Hellwig
- [PATCH 1/7] fs: remove __sync_filesystem
  - From: Christoph Hellwig

Prev by Date: [PATCH 7/7] block: simplify the block device syncing code
Next by Date: Re: [PATCH 3/7] xen-blkback: use sync_blockdev
Previous by thread: [PATCH 1/7] fs: remove __sync_filesystem
Next by thread: [PATCH 2/7] block: remove __sync_blockdev
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]