Re: [PATCH 23/29] block: use bdev_nr_sectors instead of open coding it in blkdev_fallocate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 23/29] block: use bdev_nr_sectors instead of open coding it in blkdev_fallocate
From: Jan Kara <jack@xxxxxxx>
Date: Wed, 13 Oct 2021 12:44:18 +0200
Cc: Jens Axboe <axboe@xxxxxxxxx>, Coly Li <colyli@xxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Phillip Lougher <phillip@xxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, ntfs3@xxxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx
In-reply-to: <20211013051042.1065752-24-hch@lst.de>
References: <20211013051042.1065752-1-hch@lst.de> <20211013051042.1065752-24-hch@lst.de>
User-agent: Mutt/1.10.1 (2018-07-13)

On Wed 13-10-21 07:10:36, Christoph Hellwig wrote:
> Use the proper helper to read the block device size.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR

References:
- don't use ->bd_inode to access the block device size
  - From: Christoph Hellwig
- [PATCH 23/29] block: use bdev_nr_sectors instead of open coding it in blkdev_fallocate
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 21/29] reiserfs: use bdev_nr_sectors instead of open coding it
Next by Date: Re: [PATCH 28/29] reiserfs: use sb_bdev_nr_blocks
Previous by thread: [PATCH 23/29] block: use bdev_nr_sectors instead of open coding it in blkdev_fallocate
Next by thread: Re: [PATCH 23/29] block: use bdev_nr_sectors instead of open coding it in blkdev_fallocate
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]