On Wed, Aug 25, 2021 at 10:17:57PM +0300, Dan Carpenter wrote: > On Wed, Aug 25, 2021 at 09:25:22PM +0300, Kari Argillander wrote: > > This check will be also performed in generic_file_read_iter() so we do > > not want to check this two times in a row. > > > > This was founded with Smatch > > fs/ntfs3/file.c:803 ntfs_file_read_iter() > > warn: unused return: count = iov_iter_count() > > > > Signed-off-by: Kari Argillander <kari.argillander@xxxxxxxxx> > > --- > > I cc Dan also because I am happy that I finally managed to install > > Smack and straight away I found something with it. Thank you for > > this great tool. > > Thanks! > > You got a bit lucky, because you're using the --two-passes and the truth > is I haven't looked at that in years so I'm worried it's probably not > great. You probably be better off not using the --two-passes option. :/ > I should remove it. Haha no I need it :D I was just testing what this tool can do. I also notice that --two-passes seems quite bad to read. But hey I found something! :D Good to know that you are not using it. I will not use it then. Thanks. > > regards, > dan carpenter > >
