On Tue, Aug 24, 2021 at 07:02:44PM +0300, Kari Argillander wrote: > On Tue, Aug 24, 2021 at 02:52:36PM +0300, Dan Carpenter wrote: > > Add a check for when the kzalloc() in init_rsttbl() fails. Some of > > the callers checked for NULL and some did not. I went down the call > > tree and added NULL checks where ever they were missing. > > > > Fixes: b46acd6a6a62 ("fs/ntfs3: Add NTFS journal") > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Seems ok. It is not easist file to follow. log_replay is monster and > it should be refactor in some point. I'm certain that many more bugs > will be founded there. Also at least community does not have very good > testing interface for this. There is a way to do allocation fault injection, but I haven't messed with it. My guess is that syzbot will soon start reporting a ton of bugs. ;) regards, dan carpenter