On Wed, Aug 18, 2021 at 07:33:00AM +0200, Christoph Hellwig wrote: > On Wed, Aug 18, 2021 at 04:06:47AM +0300, Kari Argillander wrote: > > In one source file there is for some reason non utf8 char. But hey this > > is fs development so this kind of thing might happen. > > Pleaese also refomat these comments while you're at it. While going > over 80 characters is ok in exceptions for readability that is per > definition never the case for a block comment. Yeah. Totally good option. I already did it and looks lot better. On Wed, Aug 18, 2021 at 07:23:40AM +0200, Christoph Hellwig wrote: > On Wed, Aug 18, 2021 at 04:06:46AM +0300, Kari Argillander wrote: > > In ntfs3 driver there is allocation made like this ntfs_malloc(). > > Patch 2/3 will converter these to kernel ones like kmalloc(). After I > > did this then checkpatch raise warnings about array allocations so I > > fix these in patch 3/3. > > > > I also notice when I made patch that there is broken utf8 char so I > > wanted first fix that because it raised some warning in my editor and > > did not want to "break" patch 2/3. So patch 1/3 address that. I did > > try to apply this and it seem to work without issues. > > So this mostly looks sensible, but I still haven't actually seen > the codebase this applies to posted anywhere as far as I can tell. Yeah that's true. Only place for mention this is here (link). I have asked that Konstantin will send patch series v28 to mailing lists. I will resist resending v4 before Konstantin has sended. https://lore.kernel.org/ntfs3/a9114805f777461eac6fbb0e8e5c46f6@xxxxxxxxxxxxxxxxxxxx/
