On 26/02/2025 17.42, Zhi Wang wrote: > On 26/02/2025 11.32, Lyude Paul wrote: >> For the whole series: >> >> Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx> >> > > Hi Lyude: > > Thanks so much for the RB. Ben found a hidden use-after-free after > enabling the KFENCE in v3.I re-spined it with a minor fixes. Please > review. Sorry for that. > I mean the problem was in v2. It has been fixed in v3. Please review. Z. > Z. > >> On Tue, 2025-02-25 at 22:53 +0000, Zhi Wang wrote: >>> Hi folks: >>> >>> Here are the v2 version of NVKM GSP RPC message handling policy which >>> solves the issue reported by Ben. More details can be found in v1 [1]. >>> >>> v2: >>> >>> - Add Fixes: tag. (Danilo) >>> - Merge some patches into one. (Danilo, Alex) >>> - Implement the policy type as an explicit enum type to leverage the >>> compiler check. (Alex) >>> - Introduce the NVKM_GSP_RPC_NOWAIT for "caller don't care" policy. >>> (Alex) >>> - Introduce the kernel doc at the same time with the changes. (Alex) >>> >>> Zhi Wang (2): >>> drm/nouveau/nvkm: factor out current GSP RPC command policies >>> drm/nouveau/nvkm: introduce new GSP reply policy >>> NVKM_GSP_RPC_REPLY_POLL >>> >>> Documentation/gpu/nouveau.rst | 3 + >>> .../gpu/drm/nouveau/include/nvkm/subdev/gsp.h | 38 +++++++-- >>> .../gpu/drm/nouveau/nvkm/subdev/bar/r535.c | 2 +- >>> .../gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 79 ++++++++++--------- >>> .../drm/nouveau/nvkm/subdev/instmem/r535.c | 2 +- >>> 5 files changed, 79 insertions(+), 45 deletions(-) >>> >> >