On Thu, 2025-02-27 at 01:35 +0000, Zhi Wang wrote:
> +/**
> + * DOC: GSP message handling policy
> + *
> + * When sending a GSP RPC command, there can be multiple cases of handling
> + * the GSP RPC messages, which are the reply of GSP RPC commands, according
> + * to the requirement of the callers and the nature of the GSP RPC
> commands.
> + *
> + * NVKM_GSP_RPC_REPLY_NOWAIT - If specified, immediately return to the
> + * caller after the GSP RPC command is issued.
> + *
> + * NVKM_GSP_RPC_REPLY_RECV - If specified, wait and receive the entire GSP
> + * RPC message after the GSP RPC command is issued.
> + *
> + */
> +enum nvkm_gsp_rpc_reply_policy {
> + NVKM_GSP_RPC_REPLY_NOWAIT = 0,
> + NVKM_GSP_RPC_REPLY_RECV,
> +};
> +
I don't think the "= 0" is necessary, as it doesn't matter what the value of
NVKM_GSP_RPC_REPLY_NOWAIT is, since you're not passing it to GSP-RM itself.
You're only using it as a switch expression in r535_gsp_rpc_handle_reply().
