Re: [PATCH v1 2/2] nouveau/svm: don't initialize ret in nouveau_atomic_range_fault()

[Alistair Popple <apopple@xxxxxxxxxx>]

On Fri, Jan 24, 2025 at 07:15:24PM +0100, David Hildenbrand wrote:
> ret will be modified immediately afterwards.

Yep. Thanks for fixing.

Reviewed-by: Alistair Popple <apopple@xxxxxxxxxx>

> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c
> index 8ea98f06d39af..2f8b8b978fc08 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_svm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
> @@ -594,7 +594,7 @@ static int nouveau_atomic_range_fault(struct nouveau_svmm *svmm,
>  	struct page *page;
>  	unsigned long start = args->p.addr;
>  	unsigned long notifier_seq;
> -	int ret = 0;
> +	int ret;
>  
>  	ret = mmu_interval_notifier_insert(&notifier->notifier, mm,
>  					args->p.addr, args->p.size,
> -- 
> 2.47.1
>