Thomas Zimmermann <tzimmermann@xxxxxxx> writes: > Rework fbdev probing to support fbdev_probe in struct drm_driver > and remove the old fb_probe callback. Provide an initializer macro > for struct drm_driver that sets the callback according to the kernel > configuration. > > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The armada driver specifies a preferred color mode of 32. As this > is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > Cc: Russell King <linux@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/armada/armada_drm.h | 11 ++- > drivers/gpu/drm/armada/armada_drv.c | 4 +- > drivers/gpu/drm/armada/armada_fbdev.c | 115 ++------------------------ > 3 files changed, 17 insertions(+), 113 deletions(-) > > diff --git a/drivers/gpu/drm/armada/armada_drm.h b/drivers/gpu/drm/armada/armada_drm.h > index c303e8c7ff6c..3c0ff221a43b 100644 [...] > @@ -108,113 +111,7 @@ static int armada_fbdev_create(struct drm_fb_helper *fbh, > > return 0; > > - err_fballoc: > +err_fballoc: Unrelated cleanup but probably not worth to split in a separate patch... > dfb->fb.funcs->destroy(&dfb->fb); > return ret; > } Acked-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat