Hi
Am 16.08.24 um 15:18 schrieb Jani Nikula:
On Fri, 16 Aug 2024, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 206328387150..7a28396abb25 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -17,6 +17,8 @@
#include <drm/drm_print.h>
#include <drm/xe_drm.h>
+#include "intel_fbdev.h"
+
#include "display/xe_display.h"
#include "instructions/xe_gpu_commands.h"
#include "regs/xe_gt_regs.h"
@@ -267,6 +269,7 @@ static struct drm_driver driver = {
.dumb_create = xe_bo_dumb_create,
.dumb_map_offset = drm_gem_ttm_dumb_map_offset,
+ INTEL_FBDEV_DRIVER_OPS,
#ifdef CONFIG_PROC_FS
.show_fdinfo = xe_drm_client_fdinfo,
#endif
Basically xe_device.c should have close to zero idea about display
details, and should not include intel_fbdev.h directly.
There's a xe_display_driver_set_hooks() call that is the right place to
set the driver->fbdev_probe hook.
It's a bit of a bummer in the sense that this prevents struct drm_driver
from being const, but that's how it already is for xe.
Thanks, I'll look into this. The was another automatic reply about a
compile error in xe wrt this callback. I guess that set_hooks helper
would fix that as well.
Best regards
Thomas
BR,
Jani.
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
