On Tue, 2024-02-27 at 15:23 +0100, Danilo Krummrich wrote: > > Store the struct device pointer used to allocate the DMA buffer in > > the nvkm_gsp_mem object. This allows nvkm_gsp_mem_dtor() to release > > the buffer without needing the nvkm_gsp. This is needed so that > > we can retain DMA buffers even after the nvkm_gsp object is deleted. > > Considering "[v4][RFC] drm/nouveau: expose GSP-RM logging buffers via > debugfs", I don't see where this one is needed. > > Do I miss anything? No, I should have deleted that last sentence before sending it out. I wrote this patch for an earlier version of my debugfs patch, but then I changed the design to not need it. However, I still think this is a good patch to include. I will revise the commit message and post a v2 when I post the next version of my debugfs patch.
