Hi Thomas, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.8-rc4 next-20240212] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-nouveau-Include-linux-backlight-h/20240212-181930 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20240212101712.23675-3-tzimmermann%40suse.de patch subject: [PATCH 2/7] fbdev: Do not include <linux/backlight.h> in header config: powerpc-ppc6xx_defconfig (https://download.01.org/0day-ci/archive/20240213/202402131349.eg8DJ3MB-lkp@xxxxxxxxx/config) compiler: powerpc-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240213/202402131349.eg8DJ3MB-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202402131349.eg8DJ3MB-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/macintosh/via-pmu-backlight.c: In function '__pmu_backlight_update_status': drivers/macintosh/via-pmu-backlight.c:74:21: error: implicit declaration of function 'backlight_get_brightness'; did you mean 'pmu_backlight_get_level_brightness'? [-Werror=implicit-function-declaration] 74 | int level = backlight_get_brightness(bd); | ^~~~~~~~~~~~~~~~~~~~~~~~ | pmu_backlight_get_level_brightness drivers/macintosh/via-pmu-backlight.c: At top level: drivers/macintosh/via-pmu-backlight.c:108:21: error: variable 'pmu_backlight_data' has initializer but incomplete type 108 | static const struct backlight_ops pmu_backlight_data = { | ^~~~~~~~~~~~~ drivers/macintosh/via-pmu-backlight.c:109:10: error: 'const struct backlight_ops' has no member named 'update_status' 109 | .update_status = pmu_backlight_update_status, | ^~~~~~~~~~~~~ >> drivers/macintosh/via-pmu-backlight.c:109:27: warning: excess elements in struct initializer 109 | .update_status = pmu_backlight_update_status, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/macintosh/via-pmu-backlight.c:109:27: note: (near initialization for 'pmu_backlight_data') drivers/macintosh/via-pmu-backlight.c: In function 'pmu_backlight_init': drivers/macintosh/via-pmu-backlight.c:136:37: error: storage size of 'props' isn't known 136 | struct backlight_properties props; | ^~~~~ drivers/macintosh/via-pmu-backlight.c:154:34: error: invalid application of 'sizeof' to incomplete type 'struct backlight_properties' 154 | memset(&props, 0, sizeof(struct backlight_properties)); | ^~~~~~ drivers/macintosh/via-pmu-backlight.c:155:22: error: 'BACKLIGHT_PLATFORM' undeclared (first use in this function) 155 | props.type = BACKLIGHT_PLATFORM; | ^~~~~~~~~~~~~~~~~~ drivers/macintosh/via-pmu-backlight.c:155:22: note: each undeclared identifier is reported only once for each function it appears in drivers/macintosh/via-pmu-backlight.c:157:14: error: implicit declaration of function 'backlight_device_register'; did you mean 'root_device_register'? [-Werror=implicit-function-declaration] 157 | bd = backlight_device_register(name, NULL, NULL, &pmu_backlight_data, | ^~~~~~~~~~~~~~~~~~~~~~~~~ | root_device_register drivers/macintosh/via-pmu-backlight.c:166:19: error: invalid use of undefined type 'struct backlight_device' 166 | level = bd->props.max_brightness; | ^~ drivers/macintosh/via-pmu-backlight.c:176:35: error: invalid use of undefined type 'struct backlight_device' 176 | bd->props.max_brightness / 15); | ^~ drivers/macintosh/via-pmu-backlight.c:179:11: error: invalid use of undefined type 'struct backlight_device' 179 | bd->props.brightness = level; | ^~ drivers/macintosh/via-pmu-backlight.c:180:11: error: invalid use of undefined type 'struct backlight_device' 180 | bd->props.power = FB_BLANK_UNBLANK; | ^~ drivers/macintosh/via-pmu-backlight.c:181:9: error: implicit declaration of function 'backlight_update_status'; did you mean 'pmu_backlight_update_status'? [-Werror=implicit-function-declaration] 181 | backlight_update_status(bd); | ^~~~~~~~~~~~~~~~~~~~~~~ | pmu_backlight_update_status >> drivers/macintosh/via-pmu-backlight.c:136:37: warning: unused variable 'props' [-Wunused-variable] 136 | struct backlight_properties props; | ^~~~~ drivers/macintosh/via-pmu-backlight.c: At top level: drivers/macintosh/via-pmu-backlight.c:108:35: error: storage size of 'pmu_backlight_data' isn't known 108 | static const struct backlight_ops pmu_backlight_data = { | ^~~~~~~~~~~~~~~~~~ drivers/macintosh/via-pmu-backlight.c:108:35: error: storage size of 'pmu_backlight_data' isn't known cc1: some warnings being treated as errors vim +109 drivers/macintosh/via-pmu-backlight.c 0094f2cdcfb6f2 Benjamin Herrenschmidt 2007-12-20 106 0094f2cdcfb6f2 Benjamin Herrenschmidt 2007-12-20 107 acc2472ed33fc5 Lionel Debroux 2010-11-16 108 static const struct backlight_ops pmu_backlight_data = { 5474c120aafe78 Michael Hanselmann 2006-06-25 @109 .update_status = pmu_backlight_update_status, 599a52d1262939 Richard Purdie 2007-02-10 110 5474c120aafe78 Michael Hanselmann 2006-06-25 111 }; 5474c120aafe78 Michael Hanselmann 2006-06-25 112 4b755999d6e0c1 Michael Hanselmann 2006-07-30 113 #ifdef CONFIG_PM d565dd3b0824b6 Benjamin Herrenschmidt 2006-08-31 114 void pmu_backlight_set_sleep(int sleep) 4b755999d6e0c1 Michael Hanselmann 2006-07-30 115 { 4b755999d6e0c1 Michael Hanselmann 2006-07-30 116 unsigned long flags; 4b755999d6e0c1 Michael Hanselmann 2006-07-30 117 4b755999d6e0c1 Michael Hanselmann 2006-07-30 118 spin_lock_irqsave(&pmu_backlight_lock, flags); d565dd3b0824b6 Benjamin Herrenschmidt 2006-08-31 119 sleeping = sleep; fa19d63488bd10 Benjamin Herrenschmidt 2008-03-03 120 if (pmac_backlight && uses_pmu_bl) { 0094f2cdcfb6f2 Benjamin Herrenschmidt 2007-12-20 121 if (sleep) { 0094f2cdcfb6f2 Benjamin Herrenschmidt 2007-12-20 122 struct adb_request req; 0094f2cdcfb6f2 Benjamin Herrenschmidt 2007-12-20 123 0094f2cdcfb6f2 Benjamin Herrenschmidt 2007-12-20 124 pmu_request(&req, NULL, 2, PMU_POWER_CTRL, 0094f2cdcfb6f2 Benjamin Herrenschmidt 2007-12-20 125 PMU_POW_BACKLIGHT | PMU_POW_OFF); 0094f2cdcfb6f2 Benjamin Herrenschmidt 2007-12-20 126 pmu_wait_complete(&req); 0094f2cdcfb6f2 Benjamin Herrenschmidt 2007-12-20 127 } else 0094f2cdcfb6f2 Benjamin Herrenschmidt 2007-12-20 128 __pmu_backlight_update_status(pmac_backlight); 0094f2cdcfb6f2 Benjamin Herrenschmidt 2007-12-20 129 } 4b755999d6e0c1 Michael Hanselmann 2006-07-30 130 spin_unlock_irqrestore(&pmu_backlight_lock, flags); 4b755999d6e0c1 Michael Hanselmann 2006-07-30 131 } d565dd3b0824b6 Benjamin Herrenschmidt 2006-08-31 132 #endif /* CONFIG_PM */ 4b755999d6e0c1 Michael Hanselmann 2006-07-30 133 00f7b29f6e9b8a Mathieu Malaterre 2017-12-26 134 void __init pmu_backlight_init(void) 5474c120aafe78 Michael Hanselmann 2006-06-25 135 { a19a6ee6cad2b2 Matthew Garrett 2010-02-17 @136 struct backlight_properties props; -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
