On Tue, Nov 07, 2023 at 05:34:43PM +0300, Dan Carpenter wrote: > Hello Ben Skeggs, > > The patch 176fdcbddfd2: "drm/nouveau/gsp/r535: add support for > booting GSP-RM" from Sep 19, 2023 (linux-next), leads to the > following Smatch static checker warning: > > drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1016 r535_gsp_rpc_unloading_guest_driver() > warn: 'rpc' isn't an ERR_PTR Some related bugs are: drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1058 r535_gsp_rpc_set_registry() warn: 'rpc' isn't an ERR_PTR drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1273 r535_gsp_rpc_set_system_info() warn: 'info' isn't an ERR_PTR drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:611 r535_gsp_rpc_rm_alloc_get() warn: 'rpc' isn't an ERR_PTR drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:667 r535_gsp_rpc_rm_ctrl_get() warn: 'rpc' isn't an ERR_PTR drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:692 r535_gsp_rpc_get() warn: 'rpc' is an error pointer or valid drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:695 r535_gsp_rpc_get() error: 'rpc' dereferencing possible ERR_PTR() drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:735 r535_gsp_rpc_push() warn: 'next' isn't an ERR_PTR drivers/gpu/drm/nouveau/nvkm/subdev/instmem/r535.c:69 fbsr_memlist() warn: 'rpc' isn't an ERR_PTR regards, dan carpenter