On Thu, 2021-03-18 at 14:39 +0200, Ville Syrjälä wrote: > On Thu, Mar 18, 2021 at 08:39:01AM +0200, Martin Peres wrote: > > On 18/03/2021 00:45, Lyude wrote: > > > From: Lyude Paul <lyude@xxxxxxxxxx> > > > > > > Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at > > > least test both of them. > > > > This adds 36 subtests, which take about 1s in average. So the runtime is > > not significantly increased on the Intel side. > > > > It also seems that Intel should add skips or fix the kernel to support > > these 32xXX format. > > Intel hw at least does not support 32x32 cursors. We should > probably just just probe the kernel to see if it accepts the > requested cursor size, and skip the subtest if not. That > would also let us remove the i915 platform specific information > from has_nonsquare_cursors(). sgtm, will respin with these changes in just a moment > -- Sincerely, Lyude Paul (she/her) Software Engineer at Red Hat Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've asked me a question, are waiting for a review/merge on a patch, etc. and I haven't responded in a while, please feel free to send me another email to check on my status. I don't bite! _______________________________________________ Nouveau mailing list Nouveau@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/nouveau
