On Tue, Mar 17, 2020 at 09:00:44PM -0400, Lyude wrote: > From: Lyude Paul <lyude@xxxxxxxxxx> > > Like igt_assert_fd(), but using igt_require() instead > > Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx> > --- > lib/igt_core.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/lib/igt_core.h b/lib/igt_core.h > index fae5f59e..b66336cf 100644 > --- a/lib/igt_core.h > +++ b/lib/igt_core.h > @@ -1008,6 +1008,18 @@ void igt_describe_f(const char *fmt, ...); > else igt_debug("Test requirement passed: %s\n", #expr); \ > } while (0) > > +/** > + * igt_require_fd: > + * @fd: file descriptor > + * > + * Skips (sub-) test if the given file descriptor is invalid. > + * > + * Like igt_require(), but displays the values being compared on failure instead > + * of simply printing the stringified expression.. igt_assert_fd has this documentation comment, but that's mistakenly copypasted from igt_assert_eq and pals. Let's not propagate the copypaste error further. -- Petri Latvala > + */ > +#define igt_require_fd(fd) \ > + igt_require_f(fd >= 0, "file descriptor " #fd " failed\n"); > + > /** > * igt_skip_on_f: > * @expr: condition to test > -- > 2.24.1 > > _______________________________________________ > igt-dev mailing list > igt-dev@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ Nouveau mailing list Nouveau@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/nouveau