On Wed, Jan 8, 2020 at 9:05 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> The ioreadX() and ioreadX_rep() helpers have inconsistent interface. On
> some architectures void *__iomem address argument is a pointer to const,
> on some not.
>
> Implementations of ioreadX() do not modify the memory under the address
> so they can be converted to a "const" version for const-safety and
> consistency among architectures.
>
> Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Thanks for getting this done!
Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
> Changes since v1:
> 1. Constify also ioreadX_rep() and mmio_insX(),
> 2. Squash lib+alpha+powerpc+parisc+sh into one patch for bisectability,
The alpha and parisc versions should be independent, I was thinking
you leave them as separate patches, but this work for me too.
I have no real opinion on the other 8 patches, I would have left
them out completely, but they don't hurt either.
Arnd
_______________________________________________
Nouveau mailing list
Nouveau@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/nouveau
