Helps very much, thank you! I think I read somewhere in that tutorial that posting your patch to kernel-newbie was a safe thing to do to get comments/criticism before submitting to the maintainer mailing list (linux-serial in this case). Is that true? Thanks again. Rob Groner > -----Original Message----- > From: Greg KH [mailto:greg@xxxxxxxxx] > Sent: Wednesday, September 23, 2015 3:44 PM > To: Rob Groner <rgroner@xxxxxxx> > Cc: kernelnewbies@xxxxxxxxxxxxxxxxx > Subject: Re: Question about "Creating first patch" guide > > On Wed, Sep 23, 2015 at 07:22:08PM +0000, Rob Groner wrote: > > The OutreachyfirstpatchSetup has been very helpful in setting up my > > computer to develop a patch to submit to the kernel overlords. > > > > > > > > I’m at the point where I’ve changed the kernel code, ran and test it, > > and see just my changes with “git diff”. What has me a little > > confused is that before I actually create the patch file (to submit to > > the appropriate mailing list), it says to actually commit the change. > > Perhaps I don’t understand how git handles commit (I primarily use > > svn), but it seems like actually committing the change is kind of > > presumptuous before even posting anything on the mailing list of those > that control the git repository. > > > > > > > > What part am I not understanding? > > You should create a branch and work on that, making a commit there, then it > is trivial to turn that into a patch, as the tutorial suggests. > > With git, everything can be local, svn requires you to push your changes to > the server, which is the big difference here. > > hope this helps, > > greg k-h _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
