On July 25, 2015 3:50:30 PM EDT, Ahmed Soliman <ahmedsoliman0x666@xxxxxxxxx> wrote: >I have sent a patch for cleaning about 40 error and 50 warning >generated checkpatch to the maintainer and all what I got in responce >is "Nack. Please do not generate patches purely based on checkpatch." >so what did I do wrong ?! should I follow checkpatch or not ?? > If you want to practice the submission process the staging tree maintainer accepts checkpatch only fixes as patches. Most maintainers feel the cost of accepting the and breaking other people's pending patches is too expensive. Alternatively, if there are no pending patches then they will likely feel the code is stable so why risk a change for no real reason. On the other hand if you submit a patch that addresses a real bug, then simultaneously doing a checkpatch related patch to the same area is a very good idea. Greg -- Sent from my Android device with K-9 Mail. Please excuse my brevity. _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
