Hi,
I have submitted my first patch on 12/30/2014 and I have not received any reply for next step like error or merge ect.
I send the email to person that get_maintainer.pl script tells me to send.
Please guide whom should I reached for this.
Below is the email
---------
This patch fixes the checkpatch.pl warning:
WARNING: Single statement macros should not use a do {} while (0) loop
I have added single statement in curly braces, because it was giving
me "WARNING: macros should not use a trailing semicolon".
Signed-off-by: Shirish Gajera <gajerashirish@xxxxxxxxx>
---
drivers/staging/skein/skein_block.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c
index 66261ab..5f46cd6 100644
--- a/drivers/staging/skein/skein_block.c
+++ b/drivers/staging/skein/skein_block.c
@@ -82,10 +82,10 @@ do { \
} while (0)
#else
/* looping version */
-#define R256(p0, p1, p2, p3, ROT, r_num) \
-do { \
- ROUND256(p0, p1, p2, p3, ROT, r_num); \
-} while (0)
+#define R256(p0, p1, p2, p3, ROT, r_num) \
+{ \
+ ROUND256(p0, p1, p2, p3, ROT, r_num); \
+}
#define I256(R) \
do { \
WARNING: Single statement macros should not use a do {} while (0) loop
I have added single statement in curly braces, because it was giving
me "WARNING: macros should not use a trailing semicolon".
Signed-off-by: Shirish Gajera <gajerashirish@xxxxxxxxx>
---
drivers/staging/skein/skein_block.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c
index 66261ab..5f46cd6 100644
--- a/drivers/staging/skein/skein_block.c
+++ b/drivers/staging/skein/skein_block.c
@@ -82,10 +82,10 @@ do { \
} while (0)
#else
/* looping version */
-#define R256(p0, p1, p2, p3, ROT, r_num) \
-do { \
- ROUND256(p0, p1, p2, p3, ROT, r_num); \
-} while (0)
+#define R256(p0, p1, p2, p3, ROT, r_num) \
+{ \
+ ROUND256(p0, p1, p2, p3, ROT, r_num); \
+}
#define I256(R) \
do { \
---------------------------
Thanks,
Shirish
_______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies