Hi Bas, > All instances of this warning refer to usage of alloc_skb using the > GFP_ATOMIC flag. Why does checkpatch show this warning? Is it not good > practice to _always_ check whether allocation succeeded or not? > > I hope someone can explain the nature of this warning and, if right, > what it should look like. I suggest you to take a look at the following thread https://lkml.org/lkml/2014/6/10/382 As a short summary to that discussion: 1. You should check the NULL pointer. 2. You shouldn't print the error. > > With kind regards, > > Bas Peters > > > > _______________________________________________ > Kernelnewbies mailing list > Kernelnewbies@xxxxxxxxxxxxxxxxx > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | leon@xxxxxxx _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
