Re: [PATCH v2 0/2] ATM: HE: Cleanup coding style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 15, 2014 at 06:26:39PM -0600, Jonathan Jin wrote:
> At Greg KH's advice, I've revised my previous formatting patch by splicing it
> into two separate patches in the same sequence. If I could get additional
> feedback, I'd very much appreciate it.
> 
> This patch sequence cleans up the following coding style issues that are
> detected by checkpatch:
>         ERROR: trailing whitespace
>         ERROR: open brace '{' following struct go on the same line
> 
> Jonathan Jin (2):
>   ATM: HE: Cleanup coding style (whitespace)
>   ATM: HE: Cleanup coding style (struct braces)
> 
>  drivers/atm/he.h | 25 +++++++++++--------------
>  1 file changed, 11 insertions(+), 14 deletions(-)

Looks good, just the one nit about the leading spaces in the changelog
entry.

But note, some maintainers don't care about patches like this, so if
they are ignored, be prepared.  If they don't get picked up in a month
or so, try a subsystem that wants these types of patches, like the
staging tree.

thanks,

greg k-h

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies




[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux