On Mon, Dec 15, 2014 at 04:23:18AM +0000, karthik nayak wrote:
>
> On Mon, Dec 15, 2014, 7:31 AM Greg KH <greg@xxxxxxxxx> wrote:
>
> On Sun, Dec 14, 2014 at 07:36:23PM -0600, Jonathan Jin wrote:
> > This patch cleans up the following coding style issues that are detected
> by
> > checkpatch:
> > ERROR: trailing whitespace
> > ERROR: open brace '{' following struct go on the same line
>
> Don't do multiple things in the same patch, make this at least 2
> patches.
>
> greg k-h
>
> (Sorry, replied on my phone, default was not set to reply all.)
>
> Wouldn't this count as one checkpatch fix patch? I mean, being the same file.
Nope, you are doing two different _types_ of checkpatch fixes. So it
needs to be more than one patch.
Remember, you need to make it as easy as possible for a maintainer to
read your patch, doing more than one thing in a patch makes it much
harder, and it gives them an easy reason to reject to it.
greg k-h
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
