Re: Submitting patches question

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2014-12-08 at 14:05 -0700, Dean Michael Ancajas wrote:
> Hi,
>   I have submitted single line patches. I was wondering what is the
> policy on the # of changes per patch? For instance the code below:
> 
>         if (Index) {
>                 data = ft1000_read_reg(dev, FT1000_REG_MAG_DPDATAL);
>         } else {
>                 data = ft1000_read_reg(dev, FT1000_REG_MAG_DPDATAH);
>         }
> 
> the braces are not necessary according to the rules. Should I
> 
> A. submit 1 patch for the "if" portion and another for the "else" on
> separate emails (i.e. two patches on separate emails)?
> 
> B. 1 patch for the whole thing (considering this is trivial change) ?
> 
> C.  2 separate patches but in 1-email only?

B.

Good luck,


Paul Bolle


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies




[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux