-------- Forwarded Message -------- Subject: Re: [PATCH] staging: Fix checkpatch error messages about unneeded space before commas in ms.c Date: Sun, 2 Nov 2014 15:56:36 +0100 From: Peter Senna Tschudin <peter.senna@xxxxxxxxx> To: Nicholas Krause <xerofoify@xxxxxxxxx> This is good! You can try to submit it. On Tue, Oct 28, 2014 at 9:25 PM, Nicholas Krause <xerofoify@xxxxxxxxx> wrote: > Fixes various checkpatch error messages about removing unneeded spaces before commas on > certain lines in ms.c. > > Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx> > --- > drivers/staging/rts5208/ms.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c > index 228e483..d77153c 100644 > --- a/drivers/staging/rts5208/ms.c > +++ b/drivers/staging/rts5208/ms.c > @@ -781,7 +781,7 @@ static int msxc_change_power(struct rtsx_chip *chip, u8 mode) > buf[4] = 0; > buf[5] = 0; > > - retval = ms_write_bytes(chip, PRO_WRITE_REG , 6, NO_WAIT_INT, buf, 6); > + retval = ms_write_bytes(chip, PRO_WRITE_REG, 6, NO_WAIT_INT, buf, 6); > if (retval != STATUS_SUCCESS) > TRACE_RET(chip, STATUS_FAIL); > > @@ -1291,7 +1291,7 @@ static int ms_write_extra_data(struct rtsx_chip *chip, > for (i = 6; i < MS_EXTRA_SIZE + 6; i++) > data[i] = buf[i - 6]; > > - retval = ms_write_bytes(chip, WRITE_REG , (6+MS_EXTRA_SIZE), > + retval = ms_write_bytes(chip, WRITE_REG, (6+MS_EXTRA_SIZE), > NO_WAIT_INT, data, 16); > if (retval != STATUS_SUCCESS) > TRACE_RET(chip, STATUS_FAIL); > @@ -1342,7 +1342,7 @@ static int ms_read_page(struct rtsx_chip *chip, u16 block_addr, u8 page_num) > data[4] = 0x20; > data[5] = page_num; > > - retval = ms_write_bytes(chip, WRITE_REG , 6, NO_WAIT_INT, data, 6); > + retval = ms_write_bytes(chip, WRITE_REG, 6, NO_WAIT_INT, data, 6); > if (retval != STATUS_SUCCESS) > TRACE_RET(chip, STATUS_FAIL); > > @@ -1619,7 +1619,7 @@ static int ms_copy_page(struct rtsx_chip *chip, u16 old_blk, u16 new_blk, > data[4] = 0x20; > data[5] = i; > > - retval = ms_write_bytes(chip, WRITE_REG , 6, NO_WAIT_INT, > + retval = ms_write_bytes(chip, WRITE_REG, 6, NO_WAIT_INT, > data, 6); > if (retval != STATUS_SUCCESS) > TRACE_RET(chip, STATUS_FAIL); > @@ -1988,7 +1988,7 @@ RE_SEARCH: > RTSX_WRITE_REG(chip, PPBUF_BASE2, 0xFF, 0x88); > RTSX_WRITE_REG(chip, PPBUF_BASE2 + 1, 0xFF, 0); > > - retval = ms_transfer_tpc(chip, MS_TM_WRITE_BYTES, WRITE_REG , 1, > + retval = ms_transfer_tpc(chip, MS_TM_WRITE_BYTES, WRITE_REG, 1, > NO_WAIT_INT); > if (retval != STATUS_SUCCESS) > TRACE_RET(chip, STATUS_FAIL); > -- > 1.9.1 > -- Peter _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies