Good to hear, I will try tomorrow to send it a correct patch fixing out the issues like the one found
in this patch in the same file. I am pretty certain I known how to do a patch how.
Nick
On 14-10-22 12:50 AM, Sudip Mukherjee wrote:
> On Tue, Oct 21, 2014 at 08:31:25PM -0700, Jeff Kirsher wrote:
>> On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause <xerofoify@xxxxxxxxx> wrote:
>>> Fix checkpatch error message with opening bracket of if statement,
>>> not being on the same line as a if statement in rtw_ap.c
>>>
>>> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
>>> ---
>>> drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> I will say, it does appear you finally got a patch right. Only issue
> i agree to that. Finally Nick has sent a patch which is not having any style error, applies properly , doesnot change the logic.
>> I have is that you corrected only one of the many instances of the
>> same problem in this file.
>> If you are going to correct one instance, might as well fix them all.
> don't you think if he tries to fix them all at one go, he will again mess up everything ?
>
> thanks
> sudip
>>
>>>
>>> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
>>> index 6b4092f..927b2a6 100644
>>> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
>>> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
>>> @@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
>>> }
>>> }
>>>
>>> - if (rtw_ht_operation_update(padapter) > 0)
>>> - {
>>> + if (rtw_ht_operation_update(padapter) > 0) {
>>> update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, false);
>>> update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, true);
>>> }
>>> --
>>> 1.9.1
>>>
>>>
>>> _______________________________________________
>>> Kernelnewbies mailing list
>>> Kernelnewbies@xxxxxxxxxxxxxxxxx
>>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>>
>>
>>
>> --
>> Cheers,
>> Jeff
>>
>> _______________________________________________
>> Kernelnewbies mailing list
>> Kernelnewbies@xxxxxxxxxxxxxxxxx
>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
