Re: A quick guide to why stand-alone checkpatch patches suck...

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 16, 2014 at 08:25:51PM -0400, Valdis Kletnieks wrote:
> In general, stand-alone patches to "fix" checkpatch whining are a Bad Idea(TM).

<snip>

And here's why checkpatch patches are a "Good Idea(TM)":
  - it teaches you how to set up your email client properly
  - it teaches you how to describe a patch properly
  - it teaches you how to submit a patch properly
  - it gives you a good feedback loop
  - it is an "easy" place to start.

But, and this is a huge BUT, which you ignored, you should ONLY submit a
checkpatch cleanup for a subsystem that has a maintainer that welcomes
them.

Like drivers/staging/*.  Checkpatch cleanups are welcome, and encouraged
there.  If you want to do a checkpatch cleanup, do it there, you will
not be yelled at.

thanks,

greg k-h

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies




[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux