Re: Bug Patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 08 Sep 2014 06:36:34 -0400, nick said:

> Found a bug and attempted to fix it
>  			sub_skb = dev_alloc_skb(nSubframe_Length + 12);
> +			if (!sub_skb)
> +				return -ENOMEM;

Nick - we've told you before to research this stuff more fully before
posting patches.  As others have pointed out, there's exactly one caller, who
wants a different return on error.

For bonus points - explain why you're returning a -ENOMEM from
a function that's declared as 'static u8 parse_subframe(...'.

This is *NOT* how you convince us that you should be allowed anywhere near
kernel code.

Attachment: pgpFRxWhvsIcF.pgp
Description: PGP signature

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux