On Mon, Sep 8, 2014 at 4:51 PM, Tobias S. Josefowitz <t.josefowitz@xxxxxxxxx> wrote: > Hi Nick, > > parse_subframe() is a static function and the only caller assumes that > skb is != NULL and would be in trouble way before parse_subframe() if > skb was indeed NULL. > > Tobi > Hi Tobi, I think Nick's patch is regarding dev_alloc_skb(nSubframe_Length + 12) ; There is no error check for the return value of dev_alloc_skb , and it can return NULL if it fails and the memory is not allocated. I admit return -ENOMEM is wrong , but still I think Nick has found something this time. sudip > On Mon, Sep 8, 2014 at 12:36 PM, nick <xerofoify@xxxxxxxxx> wrote: >> Hey Guys, >> Found a bug and attempted to fix it. I am attaching the patch, no build or checkpatch errors and >> also checked to see if I need to clean up any memory when returning, and this seems to be true. >> Nick >> >> _______________________________________________ >> Kernelnewbies mailing list >> Kernelnewbies@xxxxxxxxxxxxxxxxx >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> > > _______________________________________________ > Kernelnewbies mailing list > Kernelnewbies@xxxxxxxxxxxxxxxxx > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies _______________________________________________ Kernelnewbies mailing list Kernelnewbies@xxxxxxxxxxxxxxxxx http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
